search

jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
415 stars 366 forks source link

[All] Correcting Bearer Authorization header #698

Closed yaleman closed 1 year ago

yaleman commented 1 year ago

Currently the value for the "Authorization" header is taken from the case-insensitive "token_type" field (RFC 6750) sent by the OAuth IDP. This PR corrects for this and matches the RFC 6749 requirement of having title-cased "Bearer".

References: https://github.com/jupyterhub/oauthenticator/issues/677 and https://github.com/jupyterhub/oauthenticator/issues/676

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

consideRatio commented 1 year ago

Thank you @yaleman and thank you @jyio for the amazing resaerch in https://github.com/jupyterhub/oauthenticator/issues/677#issuecomment-1817859638 - wow!! :heart: :tada: :sunflower: