search

jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
414 stars 366 forks source link

[Google] Decouple `hosted_domain` from domain stripping usernames #733

Closed consideRatio closed 2 months ago

consideRatio commented 8 months ago

Currently, if GoogleOAuthenticator.hosted_domain is configured to a list with a single domain, the username is stripped of that domain. If another hosted_domain is added, no domains are stripped from the usernames etc.

This is a fragile configuration, where a change to hosted_domain for authorization purposes leads to changes in usernames. We should make sure those changes are decoupled from each other I think.

This isn't an urgent issue or something we need to fix, but I wanted it represented as a GitHub issue for now.

manics commented 8 months ago

I agree, I attempted this but all the tests broke so I decided to leave it for the future.