search

jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
408 stars 362 forks source link

Move allowed_groups and admin_groups to base authenticator #741

Closed yuvipanda closed 4 months ago

yuvipanda commented 4 months ago

A simplification of https://github.com/jupyterhub/oauthenticator/pull/735, moving 2 of the 3 traitlets. This is a straight up move, without any functional breaking changes.

Both of these are more useful with claim_groups_key, as that allows an external party to drive group memberships. Without that, I guess primarily this depends on membership within the JupyterHub admin UI.

Splitting this up helps us get this moving faster, as figuring out how to move claim_groups_key is going to be slightly more involved.

yuvipanda commented 4 months ago

I was wrong, looks like it's not actually easier to move just these two - I thought get_user_groups was common to all authenticators, but not the case.