jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
414 stars 366 forks source link

[Google] Add switch to strip domain from username #748

Closed 0mar closed 2 months ago

0mar commented 4 months ago

Taking a stab at #733.

I added a switch to the Google OAuthenticator to explicitly indicate whether domains should be stripped, which by default is set to False. If set to True, domain names will be stripped, and if in addition there are multiple domains specified, a warning will be produced. Perhaps this should be an error instead?

Closes #733

manics commented 4 months ago

Thanks for working on this. At the moment it's going to silently break most existing users who only have a single domain. Even if we highlight it in a changelog it's likely to be missed.

I can think of two options:

0mar commented 4 months ago

Thanks for the feedback. The second option sounds like it covers the most use cases, so I've gone with that one