jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
414 stars 365 forks source link

c.OAuthenticator.http_request_kwargs not being used #752

Open chamnab-sonn opened 2 months ago

chamnab-sonn commented 2 months ago

Bug description

when setting http_request_kwargs no request was seen at proxy logs. Assuming the proxy kwargs are not being pass on.

jupyterhub_config.py

c.OAuthenticator.http_request_kwargs = { "proxy_host": "http://10.0.8.88", "proxy_port": 8080, }

the rest of config:

c.JupyterHub.authenticator_class = 'azuread' c.OAuthenticator.oauth_callback_url = "https://[redacted]/jupyter/hub/oauth_callback" c.OAuthenticator.client_id = "[redacted]" c.OAuthenticator.client_secret = "[redacted]" c.AzureAdOAuthenticator.tenant_id = "[redacted]" c.AzureAdOAuthenticator.scope = ["openid", "email"] c.OAuthenticator.allow_all = True

Jupyterhub debugs log:

[E 2024-08-28 11:17:23.928 JupyterHub oauth2:683] Error fetching 599 POST https://login.microsoftonline.com/[redacted]/oauth2/token: Timeout while connecting

[E 2024-08-28 11:17:23.928 JupyterHub web:1875] Uncaught exception GET /jupyter/hub/oauth_callback?code=................

Traceback: Traceback (most recent call last): File "/opt/jupyterhub/lib64/python3.9/site-packages/tornado/web.py", line 1790, in _execute result = await result File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 210, in get user = await self.login_user() File "/opt/jupyterhub/lib64/python3.9/site-packages/jupyterhub/handlers/base.py", line 964, in login_user authenticated = await self.authenticate(data) File "/opt/jupyterhub/lib64/python3.9/site-packages/jupyterhub/auth.py", line 680, in get_authenticated_user authenticated = await maybe_future(self.authenticate(handler, data)) File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 1063, in authenticate token_info = await self.get_token_info(handler, access_token_params) File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 908, in get_token_info token_info = await self.httpfetch( File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 720, in httpfetch return await self.fetch( File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 684, in fetch raise e File "/opt/jupyterhub/lib64/python3.9/site-packages/oauthenticator/oauth2.py", line 663, in fetch resp = await self.http_client.fetch(req, **kwargs) tornado.simple_httpclient.HTTPTimeoutError: Timeout while connecting

manics commented 2 months ago

What version of JupyterHub and OAuthenticator are you using? Can you turn on debug logging, and show us the logs for the full authentication process?