search

jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
414 stars 366 forks source link

[All] Add `enable_pkce` config, True by default #765

Closed renan-r-santos closed 1 month ago

renan-r-santos commented 1 month ago

Fixes https://github.com/jupyterhub/oauthenticator/issues/468

renan-r-santos commented 1 month ago

By the way, I think this PR also helps a bit in getting OAuthenticator compatible with OAuth 2.1 (still in draft) as:

PKCE is required for all OAuth clients using the authorization code

renan-r-santos commented 1 month ago

Guys, I think this is ready for another round of reviews. I made a few improvements and incorporated important points that we discussed here in the enable_pkce docs. Thank you for your patience!

minrk commented 1 month ago

Thank you!