Closed kerylefondji closed 1 year ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Good suggestions, thank you!
@minrk Thanks sir
Thank you for your contribution! Since the contribution period is now over, we will close this issue.
ok thanks Sarah Gibson, it was a great pleasure for me to contribute to this issue.
Le jeu. 10 nov. 2022 à 12:08, Sarah Gibson @.***> a écrit :
Closed #54 https://github.com/jupyterhub/outreachy/issues/54 as completed.
— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/outreachy/issues/54#event-7782123238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPONPAPBGPBG7CDC7ADLE3WHTJSLANCNFSM6AAAAAARFKEKSY . You are receiving this because you authored the thread.Message ID: @.***>
What page is this for?
https://github.com/jupyterhub/outreachy/issues/38#issuecomment-1277709610
WAVE accessibility report
Wave accessiblity report
Below is the screenshot of the wave accessibility report:
The HTML element to be changed
Language missing or invalid: The HTML tag
<html xmlns="http://www.w3.org/1999/xhtml">
has to be changed.48 X very low contrast : The CSS code color of all the following has to be change:
Here is the CSS code that has to be change:
<img class="logo" src="_static/IPy_header.png" alt="Logo"> , <img src="_static/jupytercon-logo.svg" width="180px" alt="JupyterCon 2017"> and <img alt="IPython clients" src="_images/ipy_0.13.png" style="width: 400px;">.
Your proposed HTML (or CSS), after change
Add a
lang
attribute to the html element whose value represents the primary language of document. i.e<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
If the background is light, then the text color has to be dark enough so users with low vision will be able to read the text. so by changing #ce5c00 color to #c25700, the #888a85 to #6D746D the contrast errors is fix .
b) Alternative text should describe what is on the image. It is very important for screen readers because it allows describing the content of the image to the user. i.e
<img class="logo" src="_static/IPy_header.png" alt="IPython image Logo">
c) Image alt value is used to describe an image textually so that screen readers user can understand what that image is. On the other hand, the image title value is simply used to provide an image with a title, but it’s less important for screen readers user than the alt value. So by replacing the title value by alt attribute value will fix the error alert. i.e
d) Where appropriate, reword the link text so that it is more descriptive of its destination when read out of context. Remove any extraneous text like "click here”, here ..... So replacing "here" by "IPython’s Notebook Viewer" fix the alert. i.e
More info
No response