Closed AbeerTannous closed 1 year ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Just for clarification In the MORE INFO section I have used some code blocks that didn't show . instead its displayed as page elements .
Thanks for the suggestions! Can you elaborate on what you mean about indentation? Indentation of HTML code is not related to accessibility, or meaningful in HTML.
I have used some code blocks that didn't show
In markdown, code blocks must be esaped with back-ticks:
I have used a `<p>` tag and a `<li>`
produces:
I have used a <p>
tag and a <li>
Thanks for the review! My note about indentation is not related to accissability , rather its related to the HTML code , and what I meant was instead of formatting the code this way
<ul class="nav bd-sidenav bd-sidenav__home-link">
<li class="toctree-l1">
<a class="reference internal" href="intro.html">
Project Jupyter Governance
</a>
</li>
</ul>
to be like this
<ul class="nav bd-sidenav bd-sidenav__home-link">
<li class="toctree-l1">
<a class="reference internal" href="intro.html">
Project Jupyter Governance
</a>
</li>
</ul>
by formatting the code using indentation it becomes more readable by other developers and shows the relationship between the child and parent HTML elements , so for any time we need to come back to the code just like what we are doing now trying to implement the accessibility related changes, it would be much easer to track the code and find the specific elements that need to be changed .
This suggestion was under the following section "Anything more you want to share? Suggestions that don't fit in HTML/CSS changes? Add it here.".
Ah, thank you. You're right. Often, HTML is compressed for efficiency in transmission rather than human readability. Very often, the final HTML is ultimately written by machines for machines, rather than by humans for humans.
The nice thing about HTML's space-insensitivity is that you can always take the HTML that's delivered to the browser and view it in the browser's inspector - then you will see the HTML indented based on its logical hierarchy, regardless of the formatting of the file itself. That means the served HTML doesn't need to be nicely formatted to have all the benefits of nicely formatted HTML.
Got it ,Thanks for clarifying that to me .
Thank you for your contribution! Since the contribution period is now over, we will close this issue.
What page is this for?
https://jupyter.org/governance/software_steering_council.html
WAVE accessibility report
https://github.com/jupyterhub/outreachy/issues/38#issuecomment-1277869254
The HTML element to be changed
Your proposed HTML (or CSS), after change
More info
In general the HTML document has very poor indentation as well as semantic classes and structure for example the following block of code is just to display a link to the Project Jupyter Governance page , this could be done with out a list.
why are we using
<p>
inside the<li>
? lastly the classes names are not descriptive and that makes it hard for developers to keep track.