jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
142 stars 28 forks source link

[SOLVED] Need Way To push to DockerHub, preferrably in Jupyter Org #37

Closed hamelsmu closed 4 years ago

hamelsmu commented 4 years ago

@betatim @choldgraf

CORRECTION

Ooops I forgot that I don't actually need this! I made some changes in anticipation that this would happen and am forcing folks to build the container each time the action starts. So the action is actually no longer referencing github/repo2docker-action

Therefore I don't need any help. I guess I should stop trying to work late at night. My apologies for the noise.


Part of the release process of this Action is materializing all the dependencies for this Action. Two issues:

  1. Currently, this action is linked to github/repo2docker-action, but this should probably be in Jupyter so that Jupyter has control over it?

  2. I would need someone (an admin) to add the secrets to this repository DOCKER_USERNAME and DOCKER_PASSWORD

This is the workflow in this repository .github/workflows/docker.yaml

name: Docker
on: 
  push:
    branches:
      - master

jobs:
  build-action-container:
    runs-on: ubuntu-latest
    steps:

      - name: Get repo contents
        uses: actions/checkout@v2

      - name: docker login
        run: |
            echo $DOCKER_PASSWORD | docker login --username $DOCKER_USERNAME --password-stdin
            ./build_action_container.sh
        env:
          DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

Can someone help me with this?

welcome[bot] commented 4 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

hamelsmu commented 4 years ago

CORRECTION

Ooops I forgot that I don't actually need this! I made some changes in anticipation that this would happen and am forcing folks to build the container each time the action starts. So the action is actually no longer referencing github/repo2docker-action

Therefore I don't need any help. I guess I should stop trying to work late at night. My apologies for the noise.