search

jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
142 stars 28 forks source link

Add shellcheck action to lint bash #82

Open yuvipanda opened 2 years ago

choldgraf commented 2 years ago

Quick thought - could we set this up as a pre-commit hook and then use pre-commit.ci to automatically make any necessary changes, rather than just doing a lint? https://github.com/jumanjihouse/pre-commit-hooks

yuvipanda commented 2 years ago

Am happy for someone else to do that, as that is probably more time than I have now unfortunately

choldgraf commented 2 years ago

If that's too much extra work, then I'm +1 on just fixing the linting error this PR is surfacing, and merging it in 👍