jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
140 stars 27 forks source link

Use docker push to push image #85

Closed yuvipanda closed 2 years ago

yuvipanda commented 2 years ago

docker push has a couple of advantages over --push in repo2docker:

This commit also removes some code duplication - we now build the image regardless, and use the flag just to differentiate pushing. An unused bash function was also deleted.

yuvipanda commented 2 years ago

Tested to work with https://github.com/2i2c-org/utoronto-image/pull/24

yuvipanda commented 2 years ago

How do you feel about hitting the merge button, @hamelsmu? :)

yuvipanda commented 2 years ago

Thanks a lot, @hamelsmu!