search

jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
140 stars 27 forks source link

Add Github workspace as safe directory on commit local Dockerfile for Binder cache #90

Closed jerrybonnell closed 2 years ago

jerrybonnell commented 2 years ago

Address Git security issue that causes Docker builds to suddenly fail.

See https://github.com/jupyterhub/repo2docker-action/issues/89#issue-1203976137 and https://github.com/actions/checkout/issues/760

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

yuvipanda commented 2 years ago

Thank you, @jerrybonnell! Were you able to test this somewhere?

jerrybonnell commented 2 years ago

@yuvipanda We are using repo2docker action in this project. Here is our workflow and the passing build.

yuvipanda commented 2 years ago

@jerrybonnell that is a super cool project! Thank you for contributing this fix <3

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: