search

jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
140 stars 27 forks source link

Remove python install step in Dockerfile #93

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

This is already installed upstream, in https://github.com/jupyterhub/repo2docker/blob/main/Dockerfile

hamelsmu commented 1 year ago

LGTM

yuvipanda commented 1 year ago

Thanks, @hamelsmu! \o/

UncleCJ commented 1 year ago

Sorry, unintentionally commented on the commit...

Do I have a crufty setup (done ages ago) or did this actually break something supposed to work in my pipeline?

Removing login credentials for https://index.docker.io/v1/
0b6c26d149a5: Pulling from ***/advent-of-code
Digest: sha256:037860d1e04bbebd3f075f6600b33857528046ff9f9be76bccc1d7ef84a5e771
Status: Image is up to date for ***/advent-of-code:0b6c26d149a5
docker.io/***/advent-of-code:0b6c26d149a5
/create_docker_image.sh: line 190: python: command not found
Verified that ***/advent-of-code:0b6c26d149a5 is publicly visible.
dg-data commented 1 year ago

It's broken, create_docker_image.sh tries using python the PR removed when your repo is Binder cached. Quick fix is to update SHA (from the Github action log) in your Dockerfile in your-repo/binder directory. Which ironically warns NOT TO EDIT THAT FILE :)

yuvipanda commented 1 year ago

@dg-data I've reverted this change for now, will investigate deeper later!