jupyterhub / repo2docker-action

A GitHub action to build data science environment images with repo2docker and push them to registries.
MIT License
140 stars 27 forks source link

Allow passing arbitrary extra arguments to repo2docker #96

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

You can see an example of this in action in https://github.com/volcanocyber/VICTOR-notebook/pull/6, where we switch the base image to Ubuntu 22.04 by bringing in this PR: https://github.com/jupyterhub/repo2docker/pull/909

consideRatio commented 1 year ago

@GeorgianaElena what do you think about my suggested changes above?

yuvipanda commented 1 year ago

@consideRatio I've split out just the extra-args into https://github.com/jupyterhub/repo2docker-action/pull/97, will come back to the rest here once that is merged

hamelsmu commented 1 year ago

Is this good to merge?

yuvipanda commented 1 year ago

@hamelsmu yep!

hamelsmu commented 1 year ago

Ok merging. I would like the features in this PR as well 🙇🏽 Thank you for doing this.

P.S. @yuvipanda we should catch up at JupyterCon if you are going to be there