curl is broken

[tschm]

Describe the bug Triggering Image Build on mybinder.org. Unfortunately there are moving versions involved. In your container you don't specify the version for curl and users build from scratch. This results for me in

527 curl: (48) An unknown option was passed in to libcurl

To Reproduce This probably fails for any workflow using the repo2docker action. Here's an example: https://github.com/tschm/cs

Expected behavior This used to work until very recently.

[welcome[bot]]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

[willow-ahrens]

I hit this bug as well on my repo, I set continue-on-fail so it looks green for now, but the action did indeed fail with the same bug: https://github.com/willow-ahrens/Finch.jl/actions/runs/4715993868/jobs/8363320585

[tschm]

Thank you @willow-ahrens. I think it's a somewhat incomplete installation of curl with the underlying container. This bug is a classic, see for example: https://stackoverflow.com/questions/11678085/curl-48-an-unknown-option-was-passed-in-to-libcurl.

[tschm]

I have updated the Dockerfile and created a pull request. The mybinder test is passing. May I please ask @yuvipanda and @hamelsmu to help out?

[tschm]

I have released a corrected copy of the workflow, see e.g. here https://github.com/tschm/babynames/blob/main/.github/workflows/binder.yml It works (for me).

[willow-ahrens]

nice! Yeah in the meantime I switched to building my images on github actions and pushing to Docker. I'll try your fork by additionally asking binder to cache the built image.

[willow-ahrens]

Yep, it works! (That said, I can't seem to make a build on binder actually work with my github actions workflow).

[mrakitin]

We are observing the same problem while publishing the images (https://github.com/bluesky/tutorials/actions/runs/4781987486/jobs/8500926820).

[tschm]

@mrakitin Please use for now my fork, e.g.

`

cache for binder

- name: cache binder build on mybinder.org
  uses: tschm/repo2docker-action@master
  with:
    NO_PUSH: true
    MYBINDERORG_TAG: ${{ github.event.ref }}

` So instead of using Jupyter-hub use tschm. The only difference between both versions is that I have installed curl-dev in the underlying docker-image of the action. The original repo2-docker-action is currently broken for all users.

Please switch back to the official version once they have released a correction.

[tschm]

The official version has just been updated. Thank you @willow-ahrens @mrakitin for shining some additional light on this problem. And thank you to @hamelsmu for accepting the pull request. I will remove tschm/repo2docker-action within the next few days and close this issue