search

jupyterhub / repo2docker

Turn repositories into Jupyter-enabled Docker images
https://repo2docker.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.62k stars 362 forks source link

Allow notebooks to run under Julia 1.6 #1094

Open ablaom opened 3 years ago

ablaom commented 3 years ago

I may misunderstand, but my julia Project.toml file states `julia = ">=1.6, <1.7" but the build process is launching 1.5 and crashing.

Julia 1.6 is already in its third patch release 1.6.3. Also, code loading/compilation in julia 1.6 is way faster.

welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

exaexa commented 2 years ago

Hello! I'd welcome running julia 1.6 kernels in Binder too. Is there any best way to help it? (I guess I could at least help making the container or something)

manics commented 2 years ago

This needs to be done in https://github.com/jupyterhub/repo2docker which is the tool underlying BinderHub. I'll transfer the issue to that repo.

Julia is handled here: https://github.com/jupyterhub/repo2docker/tree/main/repo2docker/buildpacks/julia

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

exaexa commented 2 years ago

Oh nice, thanks.

Actually, I figured that Julia 1.6 is supported (the official clicky example on binder website for julia spawns julia 1.6.2 kernel!), but if I write julia version 1.6 into the .ipynb file, it doesn't open that saying that the kernel does not exist.

Notably, the example specifies julia-1.1 but actually gets Julia 1.6.2.

So perhaps just updating the version numbers somewhere here would fix the whole problem?

manics commented 2 years ago

I'm afraid I don't know enough about Julia. If you or someone else figures out what change is needed please add a test to ensure its not inadvertently broken in future!

ablaom commented 2 years ago

@davidanthoff Any chance you could take a look at this?