search

jupyterhub / repo2docker

Turn repositories into Jupyter-enabled Docker images
https://repo2docker.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.63k stars 362 forks source link

Tests failing in main due to dependence on deprecated `ContainerConfig` #1354

Closed yuvipanda closed 5 months ago

yuvipanda commented 5 months ago

We are looking at ContainerConfig (added in https://github.com/jupyterhub/repo2docker/pull/421) in our code. However, this option was deprecated by Docker (https://docs.docker.com/engine/deprecated/#container-and-containerconfig-fields-in-image-inspect) and removed.

This is now causing our tests to fail on main.

yuvipanda commented 5 months ago

It's really only used to get WorkingDir out. We should find a different, more explicit way to do that.