jupyterhub / repo2docker

Turn repositories into Jupyter-enabled Docker images
https://repo2docker.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.61k stars 360 forks source link

Change default shell prompt #596

Open ctb opened 5 years ago

ctb commented 5 years ago

I use binder a lot for teaching short workshops (thanks nice people!) and when we use the shell via RStudio or Jupyter terminals, the default prompt is super long and ugly and takes up the whole screen:

jovyan@jupyter-ctb-2d2019-2dsnakemake-2ducdavis-2dv7l31369

so often the first thing I have people do in my workshops is reset the prompt with PS1='$ '. While this is straightforward enough, it finally occurred to me that hey, there's no reason this kind of thing couldn't be done in repo2docker (or somewhere else)! Hence this issue.

I'm not 100% sure what the prompt should be, but something shorter would be great. Heck, you could even turn it into a binder advertisement of sorts -- maybe make it jovyan@binder: or something!

betatim commented 5 years ago

I think setting the second part (after the @) to something fixed would be good. I'd keep the username "dynamic" so people can tell they are someone else when running repo2docker locally.

Want to make a PR? I think this would be sth to define in repo2docker/buildpacks/base.py where we have the template Dockerfile.

ctb commented 5 years ago

sure thing

manics commented 3 years ago

It's been a while, but it sounds like a relatively simple change to implement. Is this something the current maintainers support if someone were to open a PR, or should we close this issue?