Closed kinow closed 3 years ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
pytest-cov failed due to missing section in .coveragerc
. Added some sections (also using JupyterHub file as reference).
Now it appears to fail due timeouts in some tests… https://github.com/kinow/sudospawner/actions
All tests passing now, building fine on GH actions for my fork :+1: ready for review
Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:
Awesome, thanks!
@minrk this is built on top of your PR #53
I've rebased it onto
master
, then replaced the.travis.yml
by a GitHub actions workflows usingjupyterhub/jupyterhub
's GH action workflow as reference.Thanks! Bruno