search

jupyterhub / sudospawner

Spawn JupyterHub single-user servers with sudo
BSD 3-Clause "New" or "Revised" License
50 stars 41 forks source link

Use GitHub Actions #66

Closed kinow closed 3 years ago

kinow commented 3 years ago

@minrk this is built on top of your PR #53

I've rebased it onto master, then replaced the .travis.yml by a GitHub actions workflows using jupyterhub/jupyterhub's GH action workflow as reference.

Thanks! Bruno

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

kinow commented 3 years ago

pytest-cov failed due to missing section in .coveragerc. Added some sections (also using JupyterHub file as reference).

Now it appears to fail due timeouts in some tests… https://github.com/kinow/sudospawner/actions

kinow commented 3 years ago

All tests passing now, building fine on GH actions for my fork :+1: ready for review

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

minrk commented 3 years ago

Awesome, thanks!