search

jupyterhub / systemdspawner

Spawn JupyterHub single-user notebook servers with systemd
BSD 3-Clause "New" or "Revised" License
92 stars 45 forks source link

ensure executable paths are absolute #129

Closed minrk closed 1 year ago

minrk commented 1 year ago

systemd requires absolute paths for executables in order to resolve as expected.

Relative path executables do not take $PATH env into account when resolving the executable, only after launching the process, so systemd-run bash -c exe works, while just systemd-run exe will not.

The default executable for a Spawner is the relative jupyterhub-singleuser, assuming $PATH will be resolved.

Fixes the failure in https://github.com/jupyterhub/the-littlest-jupyterhub/pull/915

minrk commented 1 year ago

@consideRatio added one more push with clearer comments, so should be all set from me

thanks everyone for the quick review!

consideRatio commented 1 year ago

@minrk @manics @behrmann thank you for solving this!!

consideRatio commented 1 year ago

I'll create a changelog PR soon for 1.0.1, but I'd like to squeeze in some debugging log messages as well first.