search

jupyterhub / systemdspawner

Spawn JupyterHub single-user notebook servers with systemd
BSD 3-Clause "New" or "Revised" License
92 stars 45 forks source link

Stop assuming PATH env is defined when extra_paths is set, and then initialize to os.defpath #144

Closed consideRatio closed 1 month ago

consideRatio commented 1 month ago

I'm not sure if this is sufficient to resolve issues with using extra_paths together with jupyterhub 5.2.0 where env_keep doesn't include PATH in the Spawner base class any more, but it should probably be an incremental improvement no matter what.

See debugging notes in the littlest jupyterhub distribution when trying to upgrade jupyterhub from 5.1.0 to 5.2.0.

I've not added a test for extra_paths in this project, but it gets tested via tljh though, and via https://github.com/jupyterhub/the-littlest-jupyterhub/pull/1008 I can see that this made a positive difference making tests pass where they previously failed.

consideRatio commented 1 month ago

@minrk I'd like to go for a bugfix release with this PR to make tljh 5.2.0 compatible