jupyterhub / systemdspawner

Spawn JupyterHub single-user notebook servers with systemd
BSD 3-Clause "New" or "Revised" License
92 stars 45 forks source link

Wrong version gets installed #29

Closed lbiemans closed 6 years ago

lbiemans commented 6 years ago

If you run pip install jupyterhub-systemdspawner you get version 0.9.10 installed (see: https://pypi.python.org/pypi/jupyterhub-systemdspawner/0.9.10) which contains a bug with the conversion to the correct percentage e.g. 4.0 and 4 get converted to 400.0% and 0.12 gets converted to 12.0% (see: https://github.com/jupyterhub/systemdspawner/pull/24/commits/e127095988264caaf46c3f44b78203e04cf80576). The issue is easily solved by changing '--property=CPUQuota={quota}%'.format(quota=self.cpu_limit 100) to '--property=CPUQuota={quota}%'.format(quota=int(self.cpu_limit 100)) in systemdspawner.py

yuvipanda commented 6 years ago

Heya! I've made a few releases since, so this should be solved.

Thank you for opening the issue, and apologies for the long delay in resolving!