search

jupyterhub / systemdspawner

Spawn JupyterHub single-user notebook servers with systemd
BSD 3-Clause "New" or "Revised" License
92 stars 45 forks source link

fix for Centos 7 #53

Closed mortbauer closed 5 years ago

mortbauer commented 5 years ago

I have seen #9 but from my testing I only managed to make it work if I completely remove that line.

dmpe commented 5 years ago

@yuvipanda

hansen-m commented 5 years ago

I can confirm this is still an issue with 219.

yuvipanda commented 5 years ago

Thanks for the PR, @mortbauer. Instead of commenting out the line, if you just remove it I'm happy to merge it.

yuvipanda commented 5 years ago

Thanks, @mortbauer!

subgero commented 4 years ago

@mortbauer Could you please tell us, What line are you talking about?

mortbauer commented 4 years ago

@subgero please just have a look at the pull request, it removes one line

adamboutcher commented 4 years ago

Can confirm removing this line fixed spwaning for me on CentOS 7.8

yuvipanda commented 4 years ago

I released 0.14 with this fix a week ago.

adamboutcher commented 4 years ago

Well it hasn't hit upstream into tljh yet then because I had to edit that line yesterday.

yuvipanda commented 4 years ago

@adamboutcher I've bumped it in https://github.com/jupyterhub/the-littlest-jupyterhub/pull/602.

Does TLJH run on Centos? I thought we bailed early if it isn't ubuntu...

adamboutcher commented 4 years ago

It does bail but its only an issue because they hard code apt, removing any apt lines, manually installing the deps and removing the Ubuntu check and it magically works.