search

jupyterhub / systemdspawner

Spawn JupyterHub single-user notebook servers with systemd
BSD 3-Clause "New" or "Revised" License
92 stars 45 forks source link

Added support for named-servers #78

Open scj643 opened 3 years ago

scj643 commented 3 years ago

Append the server name to the unit to allow named servers. This closes #73

This could use a better way of handling templating.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

yuvipanda commented 3 years ago

Hello! Thank you for opening this :) I think expanding {servername} is probably the way to go. Maybe steal this code from kubespawner? Not sure if we need the legacy support. We can then set the default template.

scj643 commented 3 years ago

I changed it to use _expand_user_vars and to rstrip any trailing -s

yuvipanda commented 3 years ago

That's actually a good catch, @GeorgianaElena! Using escapism seems the right way to do it.

littleyoda commented 1 year ago

Is there any chance that someone will take on this PR again?