search

jupyterhub / team-compass

A repository for team interaction, syncing, and handling meeting notes across the JupyterHub ecosystem.
http://jupyterhub-team-compass.readthedocs.io
62 stars 33 forks source link

Don't make pre-commit.ci mandatory on JupyterHub repos #697

Closed manics closed 11 months ago

manics commented 11 months ago

I think (though don't have access to check) that pre-commit.ci has been turned on for all JupyterHub repos. This is based on seeing recent PRs in repos that don't have a .pre-commit-config.yaml file showing a failed pre-commit.ci GitHub status.

I don't think it should be a blanket requirement for all repos to require pre-commit, especially those that aren't using Python.

consideRatio commented 11 months ago

I agree that since pre-commit.ci makes it error when we don't have a pre-commit-config.yaml file, we should enable pre-commit.ci one repo at the time instead.

According to audit logs the pre-commit.ci was added for all repos October 30 by @minrk. @minrk I've added back all repo's that via search had a .pre-commit-config.yaml file so that we don't get test failures to show up due to a missing pre-commit-config.yaml file for now. Is that okay?

consideRatio commented 11 months ago

@manics I think you should have access, you are listed as an Owner of the JupyterHub org. Look under the jupyterhub orgs settings -> GitHub Apps -> pre-commit.ci (Configure): https://github.com/organizations/jupyterhub/settings/installations/17782968

manics commented 11 months ago

Thanks for sorting it out!

minrk commented 11 months ago

Yeah, sorry about that. I figured it would only run if the config file was there, like most other services. Definitely don't mean to enforce it on everyone, just wanted to make it easier to adopt.