jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 339 forks source link

docs: reference nbgitpullers docs to fix outdated tljh docs #826

Closed rdmolony closed 2 years ago

rdmolony commented 2 years ago

Previous URL is broken

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 years ago

Thank you @rdmolony for noticing this! This was the tip of the iceberg as the whole section was outdated. I went ahead and revised it and updated the title to reflect it.

@GeorgianaElena @manics, what do you think?

manics commented 2 years ago

Looks good to me! Makes sense to link out to the NBGitPuller docs instead of duplicating documentation.

https://nbgitpuller.link isn't working at the moment though 😢, do you know how long it's been broken for?

consideRatio commented 2 years ago

@manics ah, I think it worked when i wrote the previous commits. I don't know about whats happened to the domain and its pointing to the github pages page: https://jupyterhub.github.io/nbgitpuller/link.html, but let's stop using it.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: