search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.04k stars 341 forks source link

TLJH Installer --showprogress-page param does not work #827

Closed gs-scooter closed 2 years ago

gs-scooter commented 2 years ago

Bug description

Customizing TLJH installer command line with the documented --showprogress-page parameter is not supported.

Expected behaviour

The installer command is executed successfully and the progress page appears on the hub UI.

Actual behaviour

Following is the output log:

[  115.151555] cloud-init[1929]: Running TLJH installer...
[  115.431584] cloud-init[1929]: usage: installer.py [-h] [--admin [ADMIN [ADMIN ...]]]
[  115.433164] cloud-init[1929]:                     [--user-requirements-txt-url USER_REQUIREMENTS_TXT_URL]
[  115.434901] cloud-init[1929]:                     [--plugin [PLUGIN [PLUGIN ...]]]
[  115.434972] cloud-init[1929]:                     [--progress-page-server-pid PROGRESS_PAGE_SERVER_PID]
[  115.435016] cloud-init[1929]: installer.py: error: unrecognized arguments: --showprogress-page
[  115.477198] cloud-init[1929]: Cloud-init v. 22.2-0ubuntu1~18.04.1 running 'modules:final' at Fri, 19 Aug 2022 19:58:47 +0000. Up 28.97 seconds.
[  115.478538] cloud-init[1929]: 2022-08-19 20:00:15,227 - cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
[  115.482540] cloud-init[1929]: 2022-08-19 20:00:15,232 - util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python3/dist-packages/cloudinit/config/cc_scripts_user.py'>) failed

How to reproduce

Create an AWS cloud formation template that has the command line as part of the UserData section of launching a new instance.

Your personal set up

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

luong-komorebi commented 2 years ago

because the right argument would be --show-progress-page instead of --showprogress-page