search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.04k stars 340 forks source link

Add the ability to define conda channels in plugins via `tljh_extra_user_conda_channels` #829

Closed JudoWill closed 2 months ago

JudoWill commented 2 years ago

This PR addresses issue #828. It adds a tljh_extra_user_conda_channels hook to allow plugin developers to change the conda channels during user environment install. Adding an extra hook seems to be the most elegant solution as it allows install logic to be encapsulated in the plugin as opposed to requiring the end-user to add it during the install command.

I've added unit-tests, integration tests, and a note to the documentation. If there are any stylistic changes you'd like, I'd be happy to adjust them.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

JudoWill commented 2 years ago

Hmm, the integration tests seem to be failing for reasons outside of my changes but the unit-tests I added pass fine.

Any thoughts?

yuvipanda commented 1 year ago

Apologies for the really late response, @JudoWill. I think this is a good and useful hook to add. I don't seem to have the rights to update this PR, but I've updated this to work with the latest master in https://github.com/jupyterhub/the-littlest-jupyterhub/pull/942 (while preserving credit for your commits). I will work on merging that if the tests pass.