search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.04k stars 340 forks source link

normalize function creates illegal username when hooked into active directory #832

Open ghost opened 2 years ago

ghost commented 2 years ago

https://github.com/jupyterhub/the-littlest-jupyterhub/blob/e7728bc1b23884cf50d452d7d165c0f56421643b/tljh/normalize.py#L18

I'm getting a username in the form of 'firstname lastname' (with a space included) back from Azure AD, which results in an error when user.py tries to create a linux user in ensure_user. I'm not sure if this is an issue with my AD setup, but in any case it seems like the normalizer should not return usernames with spaces.

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

David- commented 6 months ago

My Ubuntu Server is added to the Active Directory. I've managed to log in on the system with the pre-2000 username (DOM\DD) but not with the post-2000 username (d.david@domaine.example succeed with pam_sss but wait for 90 seconds and then failed, I can't still find why). So, I tried it on my JupyterHub, and it begin to works (if I disable apparmor) but create the system user jupyter-dom\dd and the \ is bad supported!

Apr 19 13:27:28 jupyter.domaine.example systemd[1]: jupyter-dom\dd.service: Failed to load environment files: No such file or directory
Apr 19 13:27:28 jupyter.domaine.example systemd[1]: jupyter-dom\dd.service: Failed to run 'start' task: No such file or directory
Apr 19 13:27:28 jupyter.domaine.example systemd[1]: jupyter-dom\dd.service: Failed with result 'resources'.
Apr 19 13:27:28 jupyter.domaine.example systemd[1]: Failed to start /opt/tljh/user/bin/jupyterhub-singleuser.

And when I try to delete this user in the hub admin panel, the API give a 404 because de \ is converted in a /: python3[738]: [W 2024-04-19 13:45:58.610 JupyterHub log:192] 404 DELETE /hub/api/users/dom/dd?_xsrf=[secret]

I suppose the \ character should be replaced, too.