Closed yuvipanda closed 1 year ago
I'd love to see TLJH get more up to date, and this is part of it - upgrading jupyterhub from 1 to 3!
I'm currently uncomfortable making a package upgrade as we are behind on maintenance work.
I'm open to going for a change like this to get some momentum in repo maintenance efforts, but I'd really would like the CI system to work again first.
Overall I'd be a lot more comfortable maintaining this repo if we got:
@manics has done a lot of work towards this already!
Before updating JupyterHub I think we need to
Once we've got a release we have a lot more freedom to upgrade JupyterHub and make other iterative changes
Oop, realized this is going to have to wait for #856 because Python 3.6 support has been dropped by lots of packages. Indeed, so has 3.7, so I think we should require debian 11, which has been stable for 2 years already.
Removed nteract_on_jupyter from repo2docker too https://github.com/jupyterhub/repo2docker/pull/1259
I've got this working (needs a tiny fix in hubtraf), but now GitHub's down so I can't push anywhere. Will come back to it tomorrow, if GitHub isn't prompt coming back.
All green! Had to update a couple of tests, but nothing of consequence (that is tested) appears to have broken.
yay, thank you so much, @minrk!
Given that:
I feel this is good to merge :D
I know @consideRatio is out this week. If this isn't merged by next week and there are no objections, I'll merge it. I'm happy for others to merge it before that too, of course!
The installer should install the last tagged version.... if you want to be absolutely sure then do an install and check the version is 0.2.0
and not:
https://github.com/jupyterhub/the-littlest-jupyterhub/blob/adbd41dcb023aff944a6b66c4b912b1ed382c2f9/setup.py#L5
Is the plan to add up upgrade test in a future PR before tagging 1.0.0?
I've checked, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin
installs 0.2.0, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin --version main
installs the main branch
Is the plan to add up upgrade test in a future PR before tagging 1.0.0?
I opened https://github.com/jupyterhub/the-littlest-jupyterhub/issues/868 about this, it doesn't look that hard to get done so I think yes that is worth getting done.
@manics I figure we'll go for a merge at this point given your conclusions, wdyt?
Should upgrade base python version separately
Add / update documentation[ ]
Add tests