jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 339 forks source link

update: jupyterhub 3, oauthenticator 15, systemdspawner 0.17 (user env: ipywidgets 8) #842

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

Should upgrade base python version separately

consideRatio commented 1 year ago

I'd love to see TLJH get more up to date, and this is part of it - upgrading jupyterhub from 1 to 3!

I'm currently uncomfortable making a package upgrade as we are behind on maintenance work.

I'm open to going for a change like this to get some momentum in repo maintenance efforts, but I'd really would like the CI system to work again first.

Overall I'd be a lot more comfortable maintaining this repo if we got:

@manics has done a lot of work towards this already!

manics commented 1 year ago

Before updating JupyterHub I think we need to

  1. Fix CI (I attempted and failed in https://github.com/jupyterhub/the-littlest-jupyterhub/pull/839, feel free to add to that or open a fresh PR)
  2. Tag and release a version of TLJH with JupyterHub 1 https://github.com/jupyterhub/the-littlest-jupyterhub/pull/838

Once we've got a release we have a lot more freedom to upgrade JupyterHub and make other iterative changes

minrk commented 1 year ago

Oop, realized this is going to have to wait for #856 because Python 3.6 support has been dropped by lots of packages. Indeed, so has 3.7, so I think we should require debian 11, which has been stable for 2 years already.

yuvipanda commented 1 year ago

Removed nteract_on_jupyter from repo2docker too https://github.com/jupyterhub/repo2docker/pull/1259

minrk commented 1 year ago

I've got this working (needs a tiny fix in hubtraf), but now GitHub's down so I can't push anywhere. Will come back to it tomorrow, if GitHub isn't prompt coming back.

minrk commented 1 year ago

All green! Had to update a couple of tests, but nothing of consequence (that is tested) appears to have broken.

yuvipanda commented 1 year ago

yay, thank you so much, @minrk!

Given that:

  1. The CI system is now green, in this PR
  2. https://github.com/jupyterhub/the-littlest-jupyterhub/pull/838 was merged
  3. @minrk did most of the work even though I opened the PR

I feel this is good to merge :D

yuvipanda commented 1 year ago

I know @consideRatio is out this week. If this isn't merged by next week and there are no objections, I'll merge it. I'm happy for others to merge it before that too, of course!

manics commented 1 year ago

The installer should install the last tagged version.... if you want to be absolutely sure then do an install and check the version is 0.2.0 and not: https://github.com/jupyterhub/the-littlest-jupyterhub/blob/adbd41dcb023aff944a6b66c4b912b1ed382c2f9/setup.py#L5

Is the plan to add up upgrade test in a future PR before tagging 1.0.0?

manics commented 1 year ago

I've checked, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin installs 0.2.0, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin --version main installs the main branch

consideRatio commented 1 year ago

Is the plan to add up upgrade test in a future PR before tagging 1.0.0?

I opened https://github.com/jupyterhub/the-littlest-jupyterhub/issues/868 about this, it doesn't look that hard to get done so I think yes that is worth getting done.

consideRatio commented 1 year ago

@manics I figure we'll go for a merge at this point given your conclusions, wdyt?