search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 339 forks source link

Fix broken CI #851

Closed pnasrat closed 1 year ago

pnasrat commented 1 year ago

Fix broken CI

This includes the debug PR from @manics #839 and fixes the supplemetal group issue and broken rtd build.

There appears to be some flakiness with integration tests still but have a green build triggered by an empty commit..

Fixes #830

pnasrat commented 1 year ago

Looks like adding setgroups fixes the ubuntu failures.

Just have an rtd error now

Theme error:
An error happened in rendering the page contributing/code-review.
Reason: UndefinedError("'logo' is undefined")
pnasrat commented 1 year ago

ok I'm a little confused about the merge conflict coming up here will investigate

pnasrat commented 1 year ago

Note support for 18.04 should be dropped. That might be a bigger change than for getting this working so will file a separate issue

This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002

manics commented 1 year ago

Thanks for working on this! It's been a while since I worked on this, but I think most of the additional debugging info is useful for failures so can be kept.

I think we should remove the commented out code though.

pnasrat commented 1 year ago

I’m happy to do that tomorrow in my WIP PR and then hopefully can then get it reviewed.

Pris

On Wed, Feb 8, 2023 at 19:02 Simon Li @.***> wrote:

Thanks for working on this! It's been a while since I worked on this, but I think most of the additional debugging info is useful for failures so can be kept.

I think we should remove the commented code though.

— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/the-littlest-jupyterhub/pull/851#issuecomment-1423396486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADLZXB6XYLXC6TO2N5IGDWWQXZDANCNFSM6AAAAAAUUD4QSE . You are receiving this because you authored the thread.Message ID: @.***>

-- Pris Nasrat she/her or they/them

pnasrat commented 1 year ago

Ok the 22.04 Py3.10 --upgrade fails with

Traceback (most recent call last):
[34](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:35)
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
[35](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:36)
    return _run_code(code, main_globals, None,
[36](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:37)
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
[37](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:38)
    exec(code, run_globals)
[38](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:39)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 478, in <module>
[39](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:40)
    main()
[40](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:41)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 452, in main
[41](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:42)
    ensure_user_environment(args.user_requirements_txt_url)
[42](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:43)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/installer.py", line 197, in ensure_user_environment
[43](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:44)
    with conda.download_miniconda_installer(
[44](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:45)
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
[45](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:46)
    return next(self.gen)
[46](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:47)
  File "/opt/tljh/hub/lib/python3.10/site-packages/tljh/conda.py", line 64, in download_miniconda_installer
[47](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:48)
    raise Exception("sha256sum hash mismatch! Downloaded file corrupted")
[48](https://github.com/jupyterhub/the-littlest-jupyterhub/actions/runs/4134425509/jobs/7145569451#step:9:49)
Exception: sha256sum hash mismatch! Downloaded file corrupted
pnasrat commented 1 year ago

@consideRatio would you have capacity to review and merge this, or a suggestion of another reviewer