search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 339 forks source link

require ubuntu 20.04, test on debian 11, require Python 3.8 #856

Closed minrk closed 1 year ago

minrk commented 1 year ago

I assume this isn't going to pass right away...

I removed the runs-on and Python version matrix entries for the integration tests, since these values only exercise the host system, which isn't where the tests run. The tests all actually run in containers. There's no real reason for variation there, that I can see.

closes #852 closes #813 (already seems to work fine on 22.04, we have tests running, but this makes it clear in the docs)

minrk commented 1 year ago

All set from my side. I think next steps are:

consideRatio commented 1 year ago

@minrk I see that this PR includes the commits from #843 - should we merge 843 and rebase this PR on that or similar to help with attribution?

minrk commented 1 year ago

By including the commits, attribution should be properly assigned. That was my reason for doing the merge, since I realized I re-made several of the same changes here.

consideRatio commented 1 year ago

👍 and it will close by merging this PR because the commits get merged i assume! Sounds good!

minrk commented 1 year ago

That's my understanding. Ready to merge, or do we want another set of eyes on this?

edit: nevermind, I see the request for additional review above.