search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 339 forks source link

Add upgrade test from latest release and from previous major version's latest release #868

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

I think it should be quite easy to add an upgrade test from the latest release, since we already have an upgrade test from the default branch on github.

https://github.com/jupyterhub/the-littlest-jupyterhub/blob/adbd41dcb023aff944a6b66c4b912b1ed382c2f9/.github/integration-test.py#L147-L153

z2jh has three upgrade tests:

  1. from the latest dev release (for tljh this is equivalent to the main branch)
  2. from the latest stable release (the previous release)
  3. from the latest release of the previous major version

I figure it would make sense to have the same for tljh, where we currently have test 1 but is missing 2 and 3. (EDIT: see comment below, I think I'm incorrect - maybe we are testing 2 and not 1 currently?)

consideRatio commented 1 year ago

In https://github.com/jupyterhub/the-littlest-jupyterhub/pull/842#issuecomment-1495797010 @manics wrote:

The installer should install the last tagged version.... if you want to be absolutely sure then do an install and check the version is 0.2.0 and not: https://github.com/jupyterhub/the-littlest-jupyterhub/blob/adbd41dcb023aff944a6b66c4b912b1ed382c2f9/setup.py#L5

Is the plan to add up upgrade test in a future PR before tagging 1.0.0?

I've checked, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin installs 0.2.0, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin --version main installs the main branch

Based on that, I think I was incorrect in the comment above about what upgrade test we currently do.