jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.02k stars 338 forks source link

Google Cloud troubleshooting and configuration updates #906

Closed jrdnbradford closed 1 year ago

jrdnbradford commented 1 year ago

This PR:

I hope to continue filling out these Google Cloud configuration and troubleshooting pages.

consideRatio commented 1 year ago

@jrdnbradford wiee nice!!

My main consern when reviewing docs is that its plausible to maintain long term and won't cause trouble by existing if its not getting maintained. Looking at this, I'm not so concerned because its quite clearly scoped under clear titles and sections! Nice!!!

Skimming through, I think perhaps it could be good to lead with some introduction sentences, for example the how to on increasing the VM's boot disk size could clarify with an intro sentence that the boot disk is a disk associated with the VM where the user storage also resides, and therefore one may want to increase it to provide users with more storage space.


If someone wants to help contribute with review effort, please do! Let's try get this merged next week no matter what.

jrdnbradford commented 1 year ago

@consideRatio, agreed on the intro to boot disks. Just added 6a7cbc8.

Definitely agree with worries on keeping docs maintained. For what it's worth, I'm happy to continuing devoting time to doc creation and upkeep.

consideRatio commented 1 year ago

:heart: :tada: thank you soo much @jrdnbradford!!!! This looks great and fits well in the docs structure, scoped soo tightly under a dedicated topic that I think that maintenance isn't a big issue

For reference, here are some screenshots from the new content in this PR!

image image

consideRatio commented 1 year ago

@jrdnbradford I'm also super happy to see that the images you included were quite small in kB, making the git repo easier to fetch long term.

Thank you!!!