jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.03k stars 340 forks source link

Re-install conda/mamba for every tljh upgrade (doesn't imply upgrade) #968

Closed consideRatio closed 6 months ago

consideRatio commented 7 months ago

We have previously re-installed (without upgrading) conda and mamba, and done it based on specific versions. I think we are required to do this uncodntionally though. I think based https://github.com/conda/conda/issues/12366#issuecomment-1466144007 that since tljh make use of both pip and conda/mamba to install packages via plugins, even though we mostly use pip, we must do this re-install to ensure conda/mamba is functional before an tljh upgrade.

I think we end up with requests installed via pip during the initial setup of tljh, and that sets us up for issues when we are to make an upgrade later when conda/mamba is being used via plugins. I think the reason we didn't have this error before in tests, but do now, relates to new versions of openssl have been released, and that conda/mamba automatically upgrades them.

consideRatio commented 6 months ago

@manics @minrk this may be relevant to ensure upgrade works, especially soon if users are to use the upgrade to get security patches or similar.