search

jupyterhub / the-littlest-jupyterhub

Simple JupyterHub distribution for 1-100 users on a single server
https://tljh.jupyter.org
BSD 3-Clause "New" or "Revised" License
1.05k stars 342 forks source link

Add TLJH config lockfile #976

Closed jrdnbradford closed 2 months ago

jrdnbradford commented 7 months ago

This adds a lockfile for the TLJH config. Given the reused code it seems things are due for a refactor. I partially did this by abstracting the code that retrieves the current config.

jrdnbradford commented 2 months ago

Awesome @consideRatio. It's been a while, but if I recall correctly from filelock import FileLock, Timeout caused issues outside the function scope. I think it either caused tests to fail and/or an import error. Mostly I just remember being a bit flummoxed that I couldn't get it to work outside the function scope. 🥈

consideRatio commented 2 months ago

Thanks for following up, and thank you again for working this!