search

jupyterhub / tmpauthenticator

JupyterHub authenticator that hands out temporary accounts for everyone. For use in tmpnb.org
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

Compatibility with JupyterHub v1.0.0 #18

Closed mohirio closed 5 years ago

mohirio commented 5 years ago

In the latest version of JupyterHub get_current_user is now async and throws a runtime warning: sys:1: RuntimeWarning: coroutine 'BaseHandler.get_current_user' was never awaited

This causes self.redirect(self.get_argument("next", user.url)) To throw attributeError: 'coroutine' object has no attribute 'url'

Also, visiting the user url doesn't implicity launch the user server anymore so adding self.redirect(self.get_next_url(user)) now reroutes correctly and creates a server automatically.

yuvipanda commented 5 years ago

Awesome! Thank you, @mohirio :) I'll make a release now.