Closed consideRatio closed 1 year ago
Besides importing maybe_future from jupyterhub instead of using tornado.gen.maybe_future, this is just updating the docstrings and inline comments to clarify things in a bit more detail.
The jupyterhub code base doesn't use gen.maybe_future, but instead the self defined jupyterhub.utils.maybe_future function that references different implementations based on different situations for compatibility. See https://github.com/jupyterhub/jupyterhub/blob/4.0.0/jupyterhub/utils.py#L572-L596.
Besides importing maybe_future from jupyterhub instead of using tornado.gen.maybe_future, this is just updating the docstrings and inline comments to clarify things in a bit more detail.
The jupyterhub code base doesn't use gen.maybe_future, but instead the self defined jupyterhub.utils.maybe_future function that references different implementations based on different situations for compatibility. See https://github.com/jupyterhub/jupyterhub/blob/4.0.0/jupyterhub/utils.py#L572-L596.