search

jupyterhub / tmpauthenticator

JupyterHub authenticator that hands out temporary accounts for everyone. For use in tmpnb.org
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

Document how to present /hub/login, make auto_login and login_service configurable #41

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

Since auto_login and login_service are configurable traitlets from the base class, we have only been setting the default here - it does not prevent them from being set in config.

Fixes https://github.com/jupyterhub/tmpauthenticator/issues/40

consideRatio commented 1 year ago

@yuvipanda okay it appears that login_service the Unicode configurable traitlet wasn't marked with .tag(config=True), so that made it not configurable via c.ClassName.trait_name.

I redefined it to be that. Now, what you documented works!

yuvipanda commented 1 year ago

@consideRatio one comment about making the login_service be configurable upstream as well, but otherwise lgtm.