search

jupyterhub / tmpauthenticator

JupyterHub authenticator that hands out temporary accounts for everyone. For use in tmpnb.org
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

Remove process_user and fix support for post_auth_hook #45

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

I suggest we remove this feature straight up as part of the first major release. JupyterHub admin users can make use of post_auth_hook still, and subclass developers could do whatever they want still.

For the changelog

The TmpAuthenticator.process_user function is no longer provided for subclasses to override. The configurable Authenticator.post_auth_hook can be used to accomplish the same things though.

consideRatio commented 1 year ago

@yuvipanda it turns out that we didn't have support for the configurable post_auth_hook because it had to be run by the authenticator logic, which was bypassed. I've now made sure its run again.

DRAFT: testing concludes this isn't yet functional. To be returned. UPDATE: Solved!

consideRatio commented 1 year ago

@yuvipanda things work locally now and I've setup tests for this that pass in #47, which is based on this PR.