search

jupyterhub / traefik-proxy

JupyterHub proxy implementation with traefik
https://jupyterhub-traefik-proxy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
54 stars 30 forks source link

Test all possible downloadable versions in installer automatically #130

Closed yuvipanda closed 1 year ago

yuvipanda commented 3 years ago

Right now, our installer tests only cover a subset of the URLs + hashes we make available. This makes it possible for a new traefik / etcd / consul version to slip through with wrong hashes, and we won't notice until it breaks someone somewhere.

Proposed change

Right now, everything is an integration test. We should add a unit test as well, that imports the constants / functions in jupyterhub_traefik_proxy/install.py, and test all of them.

Who would use this feature?

Anyone adding new entries to list of downloadable packages.

consideRatio commented 3 years ago

I'm not sure what is going on, but we intermittent errors related to hashes in https://github.com/jupyterhub/the-littlest-jupyterhub/pull/710 that now use the recent release of traefik-proxy, 0.3.0.

consideRatio commented 3 years ago

The intermittent errors we had related to a mistake in the TLJH and didn't have anything to do with traefik-proxy!

minrk commented 1 year ago

Closing this as the constants are gone, and all traefik versions are supported in #160