Use progress from child spawner

jupyterhub / wrapspawner

Mechanism for runtime configuration of spawners for JupyterHub

BSD 3-Clause "New" or "Revised" License

60 stars 57 forks source link

Use progress from child spawner #22

Open akhilputhiry opened 5 years ago

akhilputhiry commented 5 years ago

See https://github.com/jupyterhub/kubespawner/issues/272 for details

akhilputhiry commented 5 years ago

@minrk Let me know your thoughts

rkdarst commented 5 years ago

Note: duplicate of #21.

This method would require Python 3.5, and then we'll have to update batchspawner requirements to 3.5 in most cases. I don't mind and it would solve some other problems, but others would rather us support 3.4 longer.

rkdarst commented 5 years ago

Now batchspawner doesn't support python3.4, but should this require 3.5 too? That seems to be the main choice between this and #21.

This could be modified to handle the case of no child spawner yet (probably rare but perhaps useful), and then to directly return the child spawner method instead of running through a new generator. But that's basically #21...