Proxy current_port to child spawner, needed by batchspawner #58

jupyterhub / wrapspawner

Mechanism for runtime configuration of spawners for JupyterHub

BSD 3-Clause "New" or "Revised" License

60 stars 57 forks source link

Proxy current_port to child spawner, needed by batchspawner #58 #25

Closed rkdarst closed 5 years ago

rkdarst commented 5 years ago

This is minimal fix for compatibility jupyterhub/batchspawner#58. It would be better to do this in a more general fashion, but this is the fast fix and we can improve later.

Currently no tests here.

mbmilligan commented 5 years ago

We are going to drop the current_port trait, so this PR can be rejected, correct?

rkdarst commented 5 years ago

Yes, no longer needed for functioning as far as I know.