Remove options_form from ProfilesSpawner, is inherited via Spawner

jupyterhub / wrapspawner

Mechanism for runtime configuration of spawners for JupyterHub

BSD 3-Clause "New" or "Revised" License

60 stars 57 forks source link

Remove options_form from ProfilesSpawner, is inherited via Spawner #57

Closed MridulS closed 1 year ago

MridulS commented 1 year ago

Not sure why is this added here? The base Spawner makes options_form configurable by default. Or am I missing something here?

Also would there be interest in moving towards how kubespawner takes care of profiles? https://github.com/jupyterhub/kubespawner/blob/cd4c08d5e175e3b6d58e279c27265e6e95e6197b/kubespawner/spawner.py#L1505

Or maybe it's time to push a bit more on https://github.com/jupyterhub/wrapspawner/issues/33 :)

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

MridulS commented 1 year ago

@mbmilligan just wanted to bump this up :)

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: