Reverse patch server #51

Ph0tonic commented 6 months ago

Since https://github.com/jupyterhub/jupyterhub/pull/3810, the fix brought by #51 on master but not yet release, breaks KubeSpawner. The spawner at least doesn't start without removing this patch, using 1.0.1 works but using the version on master fails.

See https://github.com/jupyterhub/wrapspawner/pull/50#issuecomment-1055291752

To test wrapSpawner, I used the KubeSpawner inside z2jh with the following configuration.

c.ProfilesSpawner.profiles = [
    ('Kube', 'kubespawner', 'kubespawner.KubeSpawner', {
        'ip':'0.0.0.0', 'port': 0, 'cmd': None, 'path': None, 'environment': {}, 'env_keep': []}),
    # Other spawner here
]

I haven't tested with BatchSpawner yet but this is my next step, I will report any test progress here.

Fixes #54

Ph0tonic commented 5 months ago

So I managed to test this patch with batchSpawner and it's working fine :+1:

Any feedback is welcome :tada:

welcome[bot] commented 4 months ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:

minrk commented 4 months ago

Thanks for the fix! Sorry for taking forever.

Ph0tonic commented 4 months ago

Great, you are welcome @minrk ! If you could also have a look at #59, #61 and #62 it would be awesome !

jupyterhub / wrapspawner

Reverse patch server #51 #60