Open mattijsjonker opened 1 year ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Good question. We must have a command here, and one that essentially does nothing (rather than start the default cmd for the image). /bin/sh
was chosen as the most common thing to exist here. I'm not sure we can do something else - scratch
based containers by definition are unique and usually don't have anything else in them.
Perhaps what we need is to document this requirement?
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/1c9a12cd94eed6842eee985d97126b8ed99e68ce/jupyterhub/templates/image-puller/_helpers-daemonset.tpl#L118-L123
It appears that the image puller assumes that
/bin/sh
is always available. In my setup this is causing an issue because one of the configuredsingleuser.extraContainers
images isscratch
-based, resulting in CrashLookBackoffs on the continuous-image-puller pods:The image in question (https://github.com/minio/sidekick/blob/master/Dockerfile).
I remedied this by creating a custom image that does include
/bin/sh
, but I wonder if a more elegant solution is possible (e.g., a configurable check).