Open vizeit opened 9 months ago
I'm having the same problem! Any update?
Background: Its a limitation in jupyterhub/kubespawner, stemming from being a class based on the general jupyterhub Spawner class that was created a long time ago, unrelated to k8s accepted syntax of specifying cpu/memory requests and limits.
Resolution idea:
Bug description
To install custom configuration for a jupyterhub helm release using terraform, the values can be passed as yaml in the values parameter or as an individual value in the set parameter to the release function. When passing cpu value in the set parameter, zero-to-jupyter helm chart thrown the invalid type error and it is not possible to set the cpu value.
The example below provides different combinations that I tried and resulted into the same error
Also, if you try to pass memory values that are valid as per the K8 resource units specification, the spawner throws an error that the values are invalid An example that is valid as per the specification but the spawner throws an error and single user pod fails to start,
The workaround is to create a yaml file with cpu value and pass it to the values parameter
Note: I see that there was a PR 2870 made the type to string but was canceled
How to reproduce
Expected behaviour
Kubernetes resource units are string values so the values for cpu (e.g. 250m, even though it can be described as 0.25) and memory should be accepted as a string value
Actual behaviour
JupyterHub installation fails
Your personal set up
Release version: 3.1.0
Full environment
``` # paste output of `pip freeze` or `conda list` here ```Configuration
```python # jupyterhub_config.py ```Logs
``` # paste relevant logs here, if any ```