Add recommended chart labels alongside old labels (`app.kubernetes.io/...`, `helm.sh/chart`)

consideRatio commented 5 months ago

This enables us to make a breaking change in z2jh 5 where user servers restarted once or more during z2jh 4 doesn't have to be restarted as part of the breaking change then. If we did it right away, network policy enforcement would fail for old servers for example.

Before z2jh 4, we should also get kubespawner to specify app.kubernetes.io/component alongisde component. This is done in https://github.com/jupyterhub/kubespawner/pull/835.

Also, its nice to be able to provide time for people to adjust to the new labels with a period of overlapping labels. For example, grafana dashboards working with prometheus metrics could keep working in this period and at any time transition to refering to new labels, and then when we get z2jh 5 released such dashboards could have already adjusted.

Work towards #1867

manics commented 5 months ago

I think I understand what your intentions are.

test_spawn_basic already inspects some properties of the pod, do you think you could also verify the full set of labels are present? This will also make the impact of the future removal clearer.

consideRatio commented 5 months ago

Done @manics - I also fixed unrelated test failures via https://github.com/jupyterhub/action-k3s-helm/pull/116,

consideRatio commented 4 months ago

Thank you for reviewing @manics!!! :heart: :tada: :sunflower:

jupyterhub / zero-to-jupyterhub-k8s

Add recommended chart labels alongside old labels (`app.kubernetes.io/...`, `helm.sh/chart`) #3404