search

jupyterhub / zero-to-jupyterhub-k8s

Helm Chart & Documentation for deploying JupyterHub on Kubernetes
https://zero-to-jupyterhub.readthedocs.io
Other
1.56k stars 799 forks source link

Allow the addition of a ServiceAccount to the PrePuller #3439

Closed samyuh closed 5 months ago

samyuh commented 5 months ago

Proposed change

The current daemonset configuration does not permit the specification of a ServiceAccount.

Alternative options

One alternative is to allow the assignment of a custom label. However, this is not an ideal solution because our goal is for all pods to have an associated ServiceAccount.

Who would use this feature?

This feature is necessary for everyone who want to deploy pods with a ServiceAccount.

samyuh commented 5 months ago

You can check the file regarding this daemonset here: https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/main/jupyterhub/templates/image-puller/_helpers-daemonset.tpl

samyuh commented 5 months ago

Fixed this issue on the following pull request: https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/3441

Can someone take a look? @minrk

samyuh commented 5 months ago

I will close this issue since this is more likely a bug