search

jupyterhub / zero-to-jupyterhub-k8s

Helm Chart & Documentation for deploying JupyterHub on Kubernetes
https://zero-to-jupyterhub.readthedocs.io
Other
1.56k stars 799 forks source link

Not possible to add a ServiceAccount to the Prepuller #3442

Closed samyuh closed 1 month ago

samyuh commented 5 months ago

Bug description

Even though prepuller.hook.serviceaccount is properly configured, these changes aren't applied in the pods

How to reproduce

  1. Configure prepuller.hook.serviceaccount with a service account
  2. Apply the changes
  3. Check that the pod image-puller uses the default service account, even though that was not the service account we defined

Expected behaviour

The Service Account should be properly set

Actual behaviour

The Service Account used is the default and we have no way to change it

samyuh commented 5 months ago

This bug is fixed by https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/3441 Can some mantainer review it? :)

consideRatio commented 1 month ago

I made a decision about this with some relevant background discussed in https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/3441#issuecomment-2413342694.

I'm opening https://github.com/jupyterhub/zero-to-jupyterhub-k8s/issues/3545 to represent discussion about if we should work to make it possible to configure daemonset pods' serviceaccounts.